Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint extractor enhancement #1084

Merged
merged 39 commits into from
Mar 5, 2021
Merged

TVPaint extractor enhancement #1084

merged 39 commits into from
Mar 5, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 3, 2021 •
edited
Loading

Changes

  • TVPaint extractor has 2 ways how to extract output
    • first is using george command tv_savesequence which saves all visible layers used for review family
    • second is rendering each frame of each layer from instance individually and if there is more than 1 layer they are composite using PILLOW
      • this way keeps alpha channel
  • output type of extractor is always PNG except thumbnail which is always JPG
  • all instances always collect all layers related to them no matter if they are visible or not
    • instances without any visible layer are automatically turned off for publishing
  • added validator which checks if there is at least one visible layer in the instance
  • rendering range is defined with Mark In and Mark Out
    • all instances have same range
🏴 this depends on
avalon-core ynput/avalon-core#293
🏴 Pype 2.x PR
pype #1080
avalon-core ynput/avalon-core#292

@iLLiCiTiT
removed modifiable save modes from extractor
1e5d2fd
@iLLiCiTiT
imlpemented method for copying same temp image files
0ab6609
@iLLiCiTiT
implemented method that will fill frames by pre behavior of a layer
8654bca
@iLLiCiTiT
implemented method that will fill frames by post behavior of a layer
8a53aa4
@iLLiCiTiT
implemented logic of layers compositing using Pillow
0ecdfb6
@iLLiCiTiT
frame start/end are defined by mark in/out of published clip
9d62464
@iLLiCiTiT
collect both layer's position and all layer ids
e4fc43a
@iLLiCiTiT
skip savemode filling
1bf02c5
@iLLiCiTiT
removed previous logic of rendering
e1d9613
@iLLiCiTiT
collect behavior of layer ids to process
4ca8b47
@iLLiCiTiT
implemented method that will render and fill all frames of given layer
7b1e4fe
@iLLiCiTiT
layers are rendered one by one and stored by their position (order)
6eeeb72
@iLLiCiTiT
rendered frames are composite to final output
a2e2d1f
@iLLiCiTiT
added cleanup method that will remove temp image files of individial …
5779158 
…layers
@iLLiCiTiT
pass different arguments and expect different output of render method
7973229
@iLLiCiTiT
keep frame start/end as they are
2600883
@iLLiCiTiT
added some extra logs
018512b
@iLLiCiTiT
fixed case when all layers miss image for frame
9baf9aa
@iLLiCiTiT
moved composite_images to pype's tvpaint.lib
a710d12
@iLLiCiTiT
using multiprocessing to speed up compositing part
01458f6
@iLLiCiTiT
simplified extractor with tv_savesequence command
b6fd172
@iLLiCiTiT
removed unused lib
9c28c48
@iLLiCiTiT
fixed hound
9e6b8b0
@iLLiCiTiT
fix variable names
f1058f9
This was referenced Mar 3, 2021
Merged
Merged
Merged
@iLLiCiTiT iLLiCiTiT self-assigned this Mar 3, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Mar 3, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team March 3, 2021 13:44
@iLLiCiTiT
fix frame range of pass output
7e76320
@iLLiCiTiT
renamed extract sequence to extract review sequence
573011a 
# Conflicts:
#	pype/hosts/tvpaint/plugins/publish/extract_review_sequence.py
#	pype/hosts/tvpaint/plugins/publish/extract_sequence.py
#	pype/plugins/tvpaint/publish/extract_sequence.py
@iLLiCiTiT
moved back tvpaint's lib for compositing
901287a
@iLLiCiTiT
implemented extract review that can render layer by layer with alpha
ddd23d1 
# Conflicts:
#	pype/hosts/tvpaint/plugins/publish/extract_sequence.py
@iLLiCiTiT
modified extract sequence to skip compositing is rendering only one l…
7452ac7 
…ayer
@iLLiCiTiT
removed thumbnail filename variable
4ea35c2
@iLLiCiTiT
merged extractors to one extractor
da12476 
# Conflicts:
#	pype/hosts/tvpaint/plugins/publish/extract_review_sequence.py
@iLLiCiTiT
extract sequence use key word arguments in filename template
e6e4954
@iLLiCiTiT
handle "none" behavior
a34c14f
@iLLiCiTiT
add files to layer_files_by_frame on creation
9dc1e38
@iLLiCiTiT
added some debug loggins messages
b5aa524
@iLLiCiTiT
review instance stores copy of layers data
e79c8c6
@iLLiCiTiT
added validation of layers visibility
3360f99 
# Conflicts:
#	pype/hosts/tvpaint/plugins/publish/validate_layers_visibility.py
@iLLiCiTiT
modified to match pype 3 structure
3fc3355
@iLLiCiTiT
extraction is a little bit faster
673b558 
# Conflicts:
#	pype/plugins/tvpaint/publish/extract_sequence.py
@mkolar mkolar merged commit 887af4c into develop Mar 5, 2021
@mkolar mkolar deleted the feature/3_tvpaint_full_extractor branch March 12, 2021 16:04
This was referenced Apr 1, 2021
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar